-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix safari button inconsistency #141
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
style.css
Outdated
@@ -9,6 +9,7 @@ | |||
--surface: #c0c0c0; | |||
--button-highlight: #ffffff; | |||
--button-face: #dfdfdf; | |||
--button-text: #000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maked :))
style.css
Outdated
box-sizing: border-box; | ||
border: none; | ||
background: var(--surface); | ||
box-shadow: var(--border-raised-outer), var(--border-raised-inner); | ||
border-radius: 0; | ||
border-radius: 0px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit to use 0
over 0px
. not currently linting for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
solved :))
@@ -130,11 +131,14 @@ u { | |||
button, | |||
input[type="submit"], | |||
input[type="reset"] { | |||
all: unset; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this causing the text alignment to be off? https://98css-ntl6d9tp5-jdan.vercel.app/
Hello, I my name is João and this is my first PR. I saw this issue #124 open and decided to fix it. I loved this design system!
I waiting for feedbacks :)